[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-11-10 Thread mcfongtw 
Github user mcfongtw commented on the issue:

https://github.com/apache/flink/pull/4605
  
Hi, @zentol , thanks for reviewing this PR. I recalled that I put a [caveat 
](https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/connectors/cassandra.html#checkpointing-and-fault-tolerance)about
 this potential data loss in the latest C* connector documents. Since this fix 
is committed, would you like me to open another PR just to remove that warning 
message from document?


---

[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-11-10 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4605
  
I had to modify the PR more than i initially expected.

I removed the option to disable the new behavior again; after thinking 
about it more i came to the conclusion that silently losing data is never an 
acceptable behavior.
I also rewrote the tests to be more straight-forward. 


---

[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-11-08 Thread mcfongtw 
Github user mcfongtw commented on the issue:

https://github.com/apache/flink/pull/4605
  
@zentol , cool! Thanks for reviewing it!


---

[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-11-08 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4605
  
I've rebased this locally (along with some cleanup) and will merge it later 
today.


---

[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-11-06 Thread mcfongtw 
Github user mcfongtw commented on the issue:

https://github.com/apache/flink/pull/4605
  
Hi, @zentol, since there are some conflicts in this branch and a bit out of 
date from current master, I will rebase on this branch. However, I need to know 
if you are planning to review and merge this PR recently; otherwise, I could do 
that in later time. 


---

[GitHub] flink issue #4605: [FLINK-4500] [C* Connector] CassandraSinkBase implements ...

2017-09-27 Thread mcfongtw 
Github user mcfongtw commented on the issue:

https://github.com/apache/flink/pull/4605
  
@zentol, could you also take another look if the revision has addressed the 
concerns? Thank you.


---