[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread KurtYoung 
Github user KurtYoung commented on the issue:

https://github.com/apache/flink/pull/4668
  
@fhueske sure


---

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread fhueske 
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4668
  
Hi @KurtYoung, do you want to merge this to the `release-1.3` branch as 
well?


---

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread fhueske 
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4668
  
+1 to merge this


---

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread KurtYoung 
Github user KurtYoung commented on the issue:

https://github.com/apache/flink/pull/4668
  
Thanks @JingsongLi for your contribution
LGTM, +1 to merge
cc @fhueske @StephanEwen 


---

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread JingsongLi 
Github user JingsongLi commented on the issue:

https://github.com/apache/flink/pull/4668
  
## Performance
  - HashVsSortMiniBenchmark: use buildSideOuterJoin
testBuildFirst:   16s 208ms(before)10s 98ms(after)
testBuildSecond:7s 793ms(before) 6s 67ms(after)

R: @KurtYoung 



---