[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2018-01-29 Thread cjolif 
Github user cjolif commented on the issue:

https://github.com/apache/flink/pull/4675
  
I have included the exact commits of @zjureel in #5374 as I wanted to build 
on top of them. So if #5374 gets in it shouldn't be needed anymore.


---

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2018-01-29 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/4675
  
Does #5374 subsume this PR?


---

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2018-01-25 Thread cjolif 
Github user cjolif commented on the issue:

https://github.com/apache/flink/pull/4675
  
FYI I rebased it and got working results on a sample of mine.


---

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2018-01-23 Thread cjolif 
Github user cjolif commented on the issue:

https://github.com/apache/flink/pull/4675
  
@zjureel do you have by any chance an updated version of the PR against 
latest code (looks like current one conflicts)?


---

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2017-09-20 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/4675
  
Thanks for your work @zjureel. I'm currently blocked on other work at the 
moment, but it would make sense to look into this soon when I find the time.

For some initial thoughts, I think adding another module for 5.3, although 
ugly, is the only way to go now.
And yes, good thing that you've tried to reduce duplicated code as much as 
possible. 


---

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2017-09-14 Thread zjureel 
Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4675
  
@rmetzger @tzulitai I create this PR and try to fix 
[https://issues.apache.org/jira/browse/FLINK-7386(https://issues.apache.org/jira/browse/FLINK-7386).
 In the PR I do some things as follows:

1. Add `createRequestIndex` method in `ElasticsearchApiCallBridge`, then we 
can use this method to create different `RequestIndexer` instance.

2. Add flink-connector-elasticsearch5.3 project and create 
`BulkProcessorIndexer`. `ActionRequest` will be converted to `DocWriteRequest` 
in the `BulkProcessorIndexer` in the project.

What do you think? Please have a look when you're free, thanks


---