[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4790 Thanks! ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4790 Thanks, @xccui! ð I merged this, could you please close the PR? ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4790 Hi @aljoscha, I wonder if you could take a look at this PR (as well as #4819) when you are convenient. Thanks! ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4790 Hi @aljoscha, I've created another PR #4819 for the `release-1.3` branch. ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4790 @xccui Yes, you would check out the `release-1.3` branch, do your fix there and then create a PR against the `release-1.3` branch. ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4790 Thanks for the review @StephanEwen and @aljoscha. I'd like to fix this thoroughly. However, I don't have much experience working on other branches. Shall I checkout the `release-1.3` branch and edit it directly? ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4790 We actually still need to do this because we cannot remove the `writeToKafkaWithTimestamps()` methods without breaking compatibility. (They are marked as deprecated, though). @xccui For the `release-1.3` branch the fix has to be slightly modified. Are you also up for fixing that? ---
[GitHub] flink issue #4790: [FLINK-7764] [kafka] Enable the operator settings for Fli...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4790 cc @aljoscha and @pnowojski I think there is some work for Flink 1.4 to make the Kafka 0.10 sink a regular sink function, so that the code that constructs the sink transformation is not needed any more. This change would be relevant to 1.3.3 though. ---
