[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-13 Thread NicoK 
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4961
  
Fixed on master in
0e5fb0b78cd0a3ccb144071a47579eb6c3d0570a
e9e7c3372189db7e933ff59114b9ec6245838eda

Fixed on release-1.4 in
25a28ab32609c45fb8c40f717148e32fb453d2fc
9f68212603e3601e2f7a67ff93be9b15844c14da


---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-13 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4961
  
Could you please close the PR if it doesn't auto-close?


---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-13 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4961
  
This look even better now! Waiting for Travis and then I'll merge.

Thanks! 😃 



---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-10 Thread NicoK 
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4961
  
I did include your end-to-end tests (with some fixes) and the fixes for the 
errors they found. Should be fine now, let's see what travis says...


---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-08 Thread NicoK 
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4961
  
unfortunately, it seems we cannot minimize the shaded `jar` or it will not 
contain non-imported/dynamically-loaded classes like this one


---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-08 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4961
  
I added two end-to-end tests and it seems for presto this currently fails 
with:
```

 The program finished with the following exception:

org.apache.flink.client.program.ProgramInvocationException: The program 
execution failed: Failed to submit job ae34d825b54b7afe2e973627d396e722 
(WordCount Example)
at 
org.apache.flink.client.program.ClusterClient.run(ClusterClient.java:492)
at 
org.apache.flink.client.program.StandaloneClusterClient.submitJob(StandaloneClusterClient.java:105)
at 
org.apache.flink.client.program.ClusterClient.run(ClusterClient.java:456)
at 
org.apache.flink.client.program.ClusterClient.run(ClusterClient.java:444)
at 
org.apache.flink.client.program.ContextEnvironment.execute(ContextEnvironment.java:62)
at 
org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:86)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:525)
at 
org.apache.flink.client.program.PackagedProgram.invokeInteractiveModeForExecution(PackagedProgram.java:417)
at 
org.apache.flink.client.program.ClusterClient.run(ClusterClient.java:396)
at 
org.apache.flink.client.CliFrontend.executeProgram(CliFrontend.java:802)
at org.apache.flink.client.CliFrontend.run(CliFrontend.java:282)
at 
org.apache.flink.client.CliFrontend.parseParameters(CliFrontend.java:1054)
at org.apache.flink.client.CliFrontend$1.call(CliFrontend.java:1101)
at org.apache.flink.client.CliFrontend$1.call(CliFrontend.java:1098)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1556)
at 
org.apache.flink.runtime.security.HadoopSecurityContext.runSecured(HadoopSecurityContext.java:41)
at org.apache.flink.client.CliFrontend.main(CliFrontend.java:1098)
Caused by: org.apache.flink.runtime.client.JobExecutionException: Failed to 
submit job ae34d825b54b7afe2e973627d396e722 (WordCount Example)
at 
org.apache.flink.runtime.jobmanager.JobManager.org$apache$flink$runtime$jobmanager$JobManager$$submitJob(JobManager.scala:1325)
at 
org.apache.flink.runtime.jobmanager.JobManager$$anonfun$handleMessage$1.applyOrElse(JobManager.scala:447)
at 
scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36)
at 
org.apache.flink.runtime.LeaderSessionMessageFilter$$anonfun$receive$1.applyOrElse(LeaderSessionMessageFilter.scala:38)
at 
scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36)
at 
org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:33)
at 
org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:28)
at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123)
at 
org.apache.flink.runtime.LogMessages$$anon$1.applyOrElse(LogMessages.scala:28)
at akka.actor.Actor$class.aroundReceive(Actor.scala:502)
at 
org.apache.flink.runtime.jobmanager.JobManager.aroundReceive(JobManager.scala:122)
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
at akka.actor.ActorCell.invoke(ActorCell.scala:495)
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
at akka.dispatch.Mailbox.run(Mailbox.scala:224)
at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at 
scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
at 
scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at 
scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: org.apache.flink.runtime.JobException: Creating the input splits 
caused an error: null
at 
org.apache.flink.runtime.executiongraph.ExecutionJobVertex.(ExecutionJobVertex.java:262)
at 
org.apache.flink.runtime.executiongraph.ExecutionGraph.attachJobGraph(ExecutionGraph.java:801)
at 
org.apache.flink.runtime.executiongraph.ExecutionGraphBuilder.buildGraph(ExecutionGraphBuilder.java:180)
at 
org.apache.flink.runtime.jobmanager.JobManager.org$apache$flink$runtime$jobmanager$JobManager$$submitJob(JobManager.scala:1277)
... 19 more
Caused by: java.lang.ExceptionInInitializerError

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-08 Thread NicoK 
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4961
  
looks like I created a new word: `fute` ;) - fixed the typos both of you 
found


---

[GitHub] flink issue #4961: [FLINK-7973] fix shading and relocating Hadoop for the S3...

2017-11-08 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4961
  
I think this looks good now that the comments are addressed. @zentol what 
do you think?


---