[GitHub] flink issue #5096: [FLINK-8165] ParameterTool serialization fix

2017-11-29 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5096
  
Thanks for discovering and fixing this! 😃 

Merged


---

[GitHub] flink issue #5096: [FLINK-8165] ParameterTool serialization fix

2017-11-29 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5096
  
sure 👌 



---

[GitHub] flink issue #5096: [FLINK-8165] ParameterTool serialization fix

2017-11-29 Thread gyfora 
Github user gyfora commented on the issue:

https://github.com/apache/flink/pull/5096
  
@aljoscha , im having a hard time setting up my git credentials properly on 
my work laptop could you please push this for me?


---

[GitHub] flink issue #5096: [FLINK-8165] ParameterTool serialization fix

2017-11-29 Thread gyfora 
Github user gyfora commented on the issue:

https://github.com/apache/flink/pull/5096
  
yes it fails without it, will merge this


---

[GitHub] flink issue #5096: [FLINK-8165] ParameterTool serialization fix

2017-11-29 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5096
  
This looks good! 👍 I'm guessing the test fails without the fix?

@gyfora Do you want to use your committer powers and merge this to 
`release-1.4` and `master`?




---