[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-26 Thread GJL 
Github user GJL commented on the issue:

https://github.com/apache/flink/pull/5310
  
👍 


---

[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-26 Thread GJL 
Github user GJL commented on the issue:

https://github.com/apache/flink/pull/5310
  
No, I only had hard crashes in mind. One could do a directory listing and 
delete old files.


---

[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-26 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5310
  
I've rebased onto the latest master and addressed your comments @GJL with 
6eb11dd.


---

[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-26 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5310
  
Thanks for the review @GJL. Ideally we don't leave things around when no 
longer needed. Thus, which scenario other than a hard crash have you spotted 
that doesn't clean up the graphs?


---

[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-25 Thread GJL 
Github user GJL commented on the issue:

https://github.com/apache/flink/pull/5310
  
Is it acceptable behavior that sometimes Graphs don't get deleted from disk?


---