[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5327 Thanks for the update @hequn8128. The changes look good. I tested your implementation on a cluster with TPC-H data. The results were equal to the batch results and the state clean-up worked. I will merge this :-) ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 @twalthr Hi, thanks for your review. I have updated the pr according to your suggestions. Changes mainly include: - Remove changes about UpsertSink - Refactor test case name and add more test to cover code path - Add more method comments - Add another base class `NonWindowOuterJoinWithNonEquiPredicates` and move corresponding variables and functions into it. - Split `CRowWrappingMultiOutputCollector` into `CRowWrappingMultiOutputCollector` and `LazyOutputCollector`. Best, Hequn. ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 @twalthr Hi, Great to see your review and valuable suggestions. I will update my pr late next week(maybe next weekend). Thanks very much. ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5327 Thanks @hequn8128! We're pretty busy with the Flink 1.5 release right now. This will be one of the first features to add once 1.5 is out! Best, Fabian ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Hi @twalthr @walterddr The latest update refactors interfaces and functions to make code more friendly to right/full joins. The code of right/full joins are also ready and can be reached from https://github.com/hequn8128/flink/tree/outerjoin (branch:outerjoin). @fhueske It would be great if you can also take a look. Thanks all. Hequn ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Update pr according to @walterddr 's suggestions. ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 hi, @twalthr Look forward to your review, thanks :-) ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5327 Thanks for the reminder @hequn8128. I will review it in the next 2 weeks. If not, feel free to ping me again. ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Hi, @twalthr It would be great if you can take a look at the pr. I'm looking forward to finish outer join (left/right/full) before the end of March. Besides, there are a few PRs planed to optimize inner/outer joins. Thanks :) ---
