[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-29 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5351
  
yes I'll push them together.


---


[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5351
  
Cool, do you want to commit both changes (this PR and the referenced 
branch) together?


---


[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5351
  
So the `FIleBaseUtilsTest` ran without a hitch 3000 times in a row, which 
is _really_ nice.


---


[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5351
  
Taking a look at the moment. I tried it with the `BlobCacheSuccessTest` and 
get about 30-50% less failures, but this could also be due to some leak in the 
BlobServer we haven't found yet.

I'll try it with the `FileUtilsTest`, that one should be isolated from 
other components.


---


[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-24 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5351
  
@zentol I revived and rebased an old branch with an attempt to fix the 
concurrency issue of file deletes on Windows: 
https://github.com/StephanEwen/incubator-flink/commit/0504a66b82ca2afe9a40457413585ecab6d6cc33

Can you check this out, see if it works, and commit is it is helpful?


---


[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-24 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5351
  
Note that the tests may still sporadically fail due to FLINK-5659.


---