[GitHub] flink issue #5415: [FLINK-3655] [core] Support multiple paths in FileInputFo...

2018-02-15 Thread fhueske 
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/5415
  
Will merge this.


---

[GitHub] flink issue #5415: [FLINK-3655] [core] Support multiple paths in FileInputFo...

2018-02-14 Thread fhueske 
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/5415
  
Thanks for the review @zentol. 

I've addressed your feedback, improved the backwards compatibility as 
discussed offline, and added multi-path support to additional input formats.


---

[GitHub] flink issue #5415: [FLINK-3655] [core] Support multiple paths in FileInputFo...

2018-02-13 Thread fhueske 
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/5415
  
Thanks for the question @zentol. That might be a cleaner solution, but I 
don't think we could move much into the shared super class. Everything that's 
not `private` would need to be duplicated to maintain binary compatibility. 
However, most method are `protected` or `private`. 


---

[GitHub] flink issue #5415: [FLINK-3655] [core] Support multiple paths in FileInputFo...

2018-02-12 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5415
  
What would speak against creating a new FileInputFormat that supports 
multiple paths instead? Common code could be moved into a shared super class (I 
_think_ that would be allowed).


---