[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

[kl0u]

Github user kl0u commented on the issue:

https://github.com/apache/flink/pull/5691
  
Thanks for the review @zentol ! I updated the PR integrating your comments, 
or commenting on why I did not do it. Please have a look and let me know if you 
have more comments.


---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

[kl0u]

Github user kl0u commented on the issue:

https://github.com/apache/flink/pull/5691
  
@StefanRRichter and @zentol  I will ping you when I am done with the 
refactoring.


---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

[kl0u]

Github user kl0u commented on the issue:

https://github.com/apache/flink/pull/5691
  
This is ready for another review @StefanRRichter and @zentol 


---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

[kl0u]

Github user kl0u commented on the issue:

https://github.com/apache/flink/pull/5691
  
That is because cleaning up the cache is happening from another thread, 
other than the one 
accessing the serializers, and ThreadLocal does not have a clear() method 
that you can call
from another thread and clean all the state in it. Each thread can only 
clean its own state.

> On Mar 20, 2018, at 3:34 AM, sihua zhou  wrote:
> 
> @sihuazhou commented on this pull request.
> 
> In 
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalQueryableKvState.java
 :
> 
> > private final boolean areSerializersStateless;
>  
> - private final ConcurrentMap> 
serializerCache;
> + private final ConcurrentMap> 
serializerCache = new ConcurrentHashMap<>(4);
>  
> nit: just wonder why didn't use ThreadLocal> 
provided by JDK...
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

[kl0u]

Github user kl0u commented on the issue:

https://github.com/apache/flink/pull/5691
  
Can someone have a look at this? 


---