[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5704 Since we are not shading anything we could also use the Maven JAR plugin: ``` org.apache.maven.plugins maven-jar-plugin 3.0.2 package jar sql-jar ``` ---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5704 I skimmed over the changes and did not notice anything suspicious. However, I'm not familiar with the FLIP-6 submission code. I think it would be good if somebody who's more familiar with that code would have a look as well. I tried the changes on a local FLIP-6 cluster and that worked quite well. Best, Fabian ---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Github user liurenjie1024 commented on the issue: https://github.com/apache/flink/pull/5704 LGTM ---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5704 Thanks for your review @fhueske. Since the SQL Client is in an early beta, I will merge this for now. We need more tests for different deployments in the future anyway. ---