[GitHub] flink issue #5708: [FLINK-8984][network] Drop taskmanager.exactly-once.block...

2018-03-21 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/5708
  
Thanks!


---

[GitHub] flink issue #5708: [FLINK-8984][network] Drop taskmanager.exactly-once.block...

2018-03-21 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5708
  
merging.


---

[GitHub] flink issue #5708: [FLINK-8984][network] Drop taskmanager.exactly-once.block...

2018-03-19 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/5708
  
Yes, it's a valid setting, but has worse performance and whole credit based 
flow control looses it's sense. 
`taskmanager.exactly-once.blocking.data.enabled` setting was thought as a 
fallback option if there is a bug in new code path, but this is achieved by 
using `taskmanager.network.credit-based-flow-control.enabled` in two places 
(and both of those places are about using `credit-based-flow-control`).

In other words, we do not think there is a much value in allowing 
`taskmanager.network.credit-based-flow-control.enabled` enabled, but 
`taskmanager.exactly-once.blocking.data.enabled` 
disabled, and it would make the configuration more complex/confusing for 
the users.


---

[GitHub] flink issue #5708: [FLINK-8984][network] Drop taskmanager.exactly-once.block...

2018-03-19 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5708
  
What would happen if 
`taskmanager.network.credit-based-flow-control.enabled` is enabled, but 
`taskmanager.exactly-once.blocking.data.enabled` is disabled?

Is this an invalid setting?


---

[GitHub] flink issue #5708: [FLINK-8984][network] Drop taskmanager.exactly-once.block...

2018-03-16 Thread zhijiangW 
Github user zhijiangW commented on the issue:

https://github.com/apache/flink/pull/5708
  
Thanks piotr, I agree with it. 


---