[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-05-08 Thread sihuazhou
Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5879
  
Hi @zentol , will this PR go into 1.5? I think the log seems to be a bit 
noise currently when we diagnosing the job.


---


[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread sihuazhou
Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5879
  
Hi @zentol I updated the PR, it's already for another review.


---


[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread sihuazhou
Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5879
  
@zentol Thanks for you reply, I prefer the way to introduce a 
`ExpectedLifecycleException`, I think maybe it could be used in some other 
places in the future. Addressing this...


---


[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Only log the exception when ...

2018-04-23 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5879
  
I think it is fine that exceptions are logged under debug, it's just that 
we use exceptions in the normal life-cycle. I'm wondering if we could replace 
these kind of exceptions with a special `ExpectedLifecycleException?`  or 
similar that overrides `printStackTrace` to only contain the message.


---