[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 @dawidwys It's ok with me, the unrelated change should be a minor java doc hot fix. ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/5879 Thanks @sihuazhou for the contribution. LGTM for me though I would remove the unrelated change if it is ok with you. ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 Could anyone have a look at this? A minor change that would only effects the log...absolutely won't cause any regression problem, but would be helpful when user diagnosing the job according to the log... ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 @tillrohrmann I updated the PR, could you please have a look again? ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 @tillrohrmann I think would be enough to simply print the exception message in the log, if we will refactor the PRC as a second step. Will update the PR. ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5879 @sihuazhou I'm actually no longer sure whether sending exceptions as causes along with the RPC messages was the best decision. Exceptions signal an exceptional situation and should not occur in the happy case. Therefore, I'm a bit hesitant to introduce this special `normal-life-cycle-exception` because they should not exist in the first place since it is the normal life cycle. Instead, I think we should log the exception where they occur and send a `String reason` which can be logged on the remote component. That way we should get rid of most of the exceptions being printed on `DEBUG`. As a first step to get there, I think it would be enough to simply print the exception message in the log statement. That way we would get rid of the stack traces and don't have to introduce a special exception type. As a second step, we can refactor the RPC interfaces which have the `Exception cause` parameters. What do you think? FLINK-9277 is related but not directly the same. The scope of this issue is to decrease the redundant messages which occur when releasing a shared slot starting from the leafs. ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 Hi @tillrohrmann , thanks for your reply, @zentol proposed to introduce a `normal-life-cycle exception` in his previous review, the `normal-left-cycle exception` would only log the exception messages when we try to log it. In that way, we could only log the exception message for happy case and log the stack trace for unhappy case, the changes has been covered in this PR, what do you think of that way? Or do you think I should revert it and just simply logging the exception message? ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5879 Thanks for the contribution @sihuazhou. You're right that the log output of the `SlotPool` component is a bit too noisy and should not log the full stack trace in the happy case. What about not logging the stack traces at all and simply logging the exception messages instead? ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 cc @StephanEwen ---
[GitHub] flink issue #5879: [FLINK-9215][resoucemanager] Reduce noise in SlotPool's l...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5879 cc @tillrohrmann ---
