[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[zentol]

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5936
  
merging.


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5936
  
Looks good, thanks.

+1 to merge this


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[yanghua]

Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5936
  
cc @StephanEwen , here is the dependency tree : 

```
[INFO] org.apache.flink:flink-metrics-prometheus:jar:1.6-SNAPSHOT
[INFO] +- io.prometheus:simpleclient:jar:0.3.0:compile
[INFO] \- io.prometheus:simpleclient_httpserver:jar:0.3.0:compile
[INFO]+- (io.prometheus:simpleclient:jar:0.3.0:compile - omitted for 
duplicate)
[INFO]\- io.prometheus:simpleclient_common:jar:0.3.0:compile
[INFO]   \- (io.prometheus:simpleclient:jar:0.3.0:compile - omitted for 
duplicate)
```


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5936
  
Yes, before giving +1 to this commit, we need to check that this introduces 
no new transitive dependency, or need to make sure that dependency is not an 
issue.


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[yanghua]

Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5936
  
Is there any problem about this upgrading?  Does you mean I should add the 
dependency tree here as a comment? 


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5936
  
Could you add the dependency tree of the upgraded Prometheus dependency to 
check?


---