[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/6019 @StefanRRichter & @sihuazhou thanks u guys ---
[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6019 Yes, the only reason I did not start with this is that I first wanted to wait for the completion and merge of the RocksDB timer service to have a complete picture. ---
[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6019 @StefanRRichter I definitely agree with your point! The timers should be considered as keyed state is a beautiful way to go! ---
[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6019 @sihuazhou my plan was to integrate the timer service more closely with the keyed state backends, starting from the point that we are merging the PR for timers in RocksDB. I think timers should just be considered as keyed state and eventually become part of the keyed state backend's snapshot. @makeyang with the above comment, that essentially means that with the work on the RocksDB timer service we are planning to have a larger rewrite of how snapshotting for timer works anyways. I have also concrete plans and work for doing this for the heap timer service, as well as including a efficient way to delete timers. All this unfortunately does not match too well with this PR. I suggest that this can be closed because we will address this issue for the next release in somewhat more holistic way. ---
[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6019 I wonder can you introduce a `HeapState` which scoped to `key group` to support timer service. This way timer service is backed by keyed state backend, which looks like a beautiful things. ---
