[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-27 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6086
  
cc @tillrohrmann @zentol 


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6086
  
will fix things while merging...


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread alpinegizmo
Github user alpinegizmo commented on the issue:

https://github.com/apache/flink/pull/6086
  
@zentol I think the baseurl variable also needs to be changed -- for a 
stable release, it should not point to master.


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6086
  
@zentol I have tried to switch to release-1.5 and fix it, but it seems in 
release-1.5 branch, I can not send a PR correctly, the PR will contains many 
changes.


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6086
  
@alpinegizmo nice catch!


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6086
  
merged, @yanghua please close the PR. Thanks!


---


[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6086
  
ok, closing...


---