[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6353 @tison1 there are too many commits, you can use `git rebase -i [commit-id]` to squash them, then use `git push -f xxx xxx` to force update the PR. ---
[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6353 Fix unstable case, the problem is code below, that may assign `constraints` to a long array and then to a short array, which cause out of index exception. to solve it we could init `constraints` in object construct. https://github.com/apache/flink/blob/056486a1b81e9648a6d3dc795e7e2c6976f8388c/flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroup.java#L87-L91 ---
[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6353 This pr cause `HITSITCase` unstable, I retrigger ci two times to get more info going to fix it. ---
[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6353 I think `ExecutionGraphConstructionTest` covers it. ---
[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6353 you are right, this PR used to improve the performance when creating ejv, I did not make sure the exist test cases for `attachJobGraph ` covered the exception test. if not, I suggest add some exception test, because this PR changed the way of processing exception. ---
[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6353 the existing tests verify correctness. I will take a try to give out a benchmark report since this PR is more relevant to performance. ---
