[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-72861601 Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/7ac6447f. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-72561341 +1 @rmetzger Can you create a JIRA for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-71490635 LGTM I suspect that the travis fail is caused by faulty colocated subslot disposal. Should be fixed with #317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-71595710 I think in the current state, this makes sense. I wrote the interface like it was, because it would enable implementations that does not compute/provide all splits on all machines. Think of a collection input format where we send a different subset of the collection to all each node (not supported in the runtime now, but might be at some point). I guess we can realize something similar by splitting on the client and then sending the sub set iterators directly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/338 [Discuss] Simplify SplittableIterator interface While working on something, I found the SplittableIterator interface unnecessary complicated. Let me know if you agree to merge this simplification. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink fix_interface Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #338 commit 4c2e3fb272c263d149e7b839fb2d9d496232a8be Author: Robert Metzger rmetz...@apache.org Date: 2015-01-25T18:52:02Z Simplify SplittableIterator interface commit fc0aff770fc51f7b944c6ef1c7f17c4a79d0c2ca Author: Robert Metzger rmetz...@apache.org Date: 2015-01-25T18:55:46Z fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
