[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[ajaybhat]

GitHub user ajaybhat opened a pull request:

https://github.com/apache/flink/pull/296

[FLINK-1183] Generate gentle notification message when Flink is started 
with Java 6

I've closed the [previous PR ] (https://github.com/apache/flink/pull/277) 
in favor of this new one. Pls review it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajaybhat/flink FLINK-1183

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #296


commit 5863ead371ec04ea469315d884e31a268e7fc516
Author: Ajay Bhat 
Date:   2015-01-10T19:21:11Z

[FLINK-1183] Generate gentle notification message when Flink is started 
with Java 6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69552459
  
Thanks for the PR but I vote to postpone such a warning message.

We didn't have a real consensus on the issue (see 
http://mail-archives.apache.org/mod_mbox/flink-dev/201411.mbox/%3ccanc1h_tz4kqxjiicmfjlqoxhebfrd1uatr1fn0jaywz-uec...@mail.gmail.com%3E).
 Currently, I don't see any fundamental reason to drop the support or warn 
about dropping the support. In any case, your proposal is confusing as Flink 
runs perfectly fine with Java 6.

Any opinions on this?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69552932
  
Hi,
I agree that the message is not correct. Flink will run very well with Java 
6.
BUT: I think we should print a warning because Java 6 is EOL. It is 
actually a security issue to run java 6 because it isn't patched anymore.
So I would certainly vote for having a warning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69556043
  
I would be fine with such a message if it was more "gentle". ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69587009
  
I would love to keep the PR with modified message about Flink is running in 
Java6 . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69843776
  
I agree. We should print a notification message that tells the user that it 
is not recommended to run on Java6 due to its EOL. 
As @rmetzger said, Flink runs fine with Java6 but this might change in the 
future and we want to prepare users for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[StephanEwen]

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69970228
  
How about setting the message to something like

 "Warning: You are running Flink with Java 6, which is not maintained any 
more by Oracle or the OpenJDK community. Flink currently supports Java 6, but 
the support for Java 6 may be stopped in future versions due to the 
unavailability of bug fixes security patched."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-69971212
  
+1 gentler and informative =)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[ajaybhat]

Github user ajaybhat commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-70046292
  
Thanks for the comments. Do you think the new message is better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-70087926
  
Yes +1 for the new message.

I will merge this in the next batch. It's not super important, but I think 
this should go into 0.8.0 if there is a new RC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/296#issuecomment-70090914
  
I think its fine to just merge it to the release-0.8 branch
It will then automatically go into 0.8.1. I'll create a version in JIRA

On Thu, Jan 15, 2015 at 2:52 PM, Ufuk Celebi 
wrote:

> Yes +1 for the new message.
>
> I will merge this in the next batch. It's not super important, but I think
> this should go into 0.8.0 if there is a new RC.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



-- 
Robert Metzger, Kontakt: metzg...@web.de, Mobil: 0171/7424461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/296


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---