[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/299#issuecomment-70226685
  
The change looks good. I would like to see some test cases there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-16 Thread twalthr
Github user twalthr commented on the pull request:

https://github.com/apache/flink/pull/299#issuecomment-70255146
  
There are test cases. I have adapted the existing ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/299#issuecomment-70269761
  
Oh, yes .. sorry. I need to be more careful when reviewing pull requests.

+1 to merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---