[GitHub] flink pull request: [FLINK-1542] Test case at BlobUtilsTest should...

2015-02-24 Thread uce
Github user uce commented on the pull request:

https://github.com/apache/flink/pull/396#issuecomment-75733680
  
You can do `:+1:` on GitHub. :neckbeard:

http://www.emoji-cheat-sheet.com/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1542] Test case at BlobUtilsTest should...

2015-02-16 Thread hsaputra
Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/396#issuecomment-74558015
  
Thanks for the review Ufuk and Stephan.

Also thx for Stephan for merging it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1542] Test case at BlobUtilsTest should...

2015-02-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/396


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1542] Test case at BlobUtilsTest should...

2015-02-13 Thread hsaputra
GitHub user hsaputra opened a pull request:

https://github.com/apache/flink/pull/396

[FLINK-1542] Test case at BlobUtilsTest should not assume user could not 
create new item in root directory

[FLINK-1542] Test case at BlobUtilsTest should not assume user could not 
create new item in root directory

Sometimes, user that run tests could have write access to root dir such as 
creating /cannot-create-this
is possible, hence to exception thrown.

Need to construct a Flink test directory under directory specified under 
java.io.tmpdir and change the permission to not allow create new
directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hsaputra/flink FLINK-1542_fix_BlobUtilsTest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #396


commit c56044ef5cd072a3684dfe7b723f359e0642f04e
Author: Henry Saputra henry.sapu...@gmail.com
Date:   2015-02-13T21:44:29Z

[FLINK-1542] Test case at BlobUtilsTest should not assume user could not 
create new item in root directory

Sometimes, user that run tests could have write access to root dir such as 
creating /cannot-create-this
is possible, hence to exception thrown.

Need to construct a Flink test directory under directory specified under 
java.io.tmpdir and change the permission to not allow create new
directory.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---