[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2016-04-03 Thread shghatge
Github user shghatge closed the pull request at:

https://github.com/apache/flink/pull/923


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-21 Thread vasia
Github user vasia commented on the pull request:

https://github.com/apache/flink/pull/923#issuecomment-123394302
  
Hi @shghatge!

The comments I left on #892 apply here as well. The difference would be 
that the neighborhoods of each of the neighbors will be represented as a bloom 
filter.

It would also be nice to make the bloom filter parameters (size, number of 
hash functions, hash function) configurable, so that the use can adjust the 
false positives and size based on their use-case.
What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-20 Thread andralungu
Github user andralungu commented on the pull request:

https://github.com/apache/flink/pull/923#issuecomment-122868758
  
Could you also do a git ammend to reference the correct jira issue in the 
commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-20 Thread shghatge
Github user shghatge commented on the pull request:

https://github.com/apache/flink/pull/923#issuecomment-123051521
  
Updated PR
@vasia I removed the Vertex Centric Iteration :) Hope this method is okay.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---