[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1085


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1085#issuecomment-137093481
  
Very good fix!

+1 to merge both into `master` and `0.10-milestone1`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread mxm
Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1085#issuecomment-137088288
  
During a Flink training, many people were experiencing this problem. I'd 
also like to merge this to the Milestone branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread mxm
GitHub user mxm opened a pull request:

https://github.com/apache/flink/pull/1085

[FLINK-2607][quickstart] ignore signature files when creating fat jar



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/flink quickstart

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1085.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1085


commit 9bc513129755b82a9b71b3b21c7ab4d6a0305cf8
Author: Maximilian Michels 
Date:   2015-09-02T10:21:49Z

[FLINK-2607][quickstart] ignore signature files when creating fat jar




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2607][quickstart] ignore signature file...

2015-09-02 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1085#issuecomment-137095491
  
+1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---