[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1189#issuecomment-144136876 Build passes, will squash commits and merge ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1189#issuecomment-144114134 Thanks guys, updated based comments. Will merge end of day if no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1189#discussion_r40695062
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/utils/ExampleUtils.java
---
@@ -117,7 +117,7 @@ public void configure(Configuration parameters) {
new FlatMapFunction>() {
@Override
public void flatMap(Long key,
- Collector> out)
+
Collector> out)
--- End diff --
Thank! Will update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1189#issuecomment-144011547 Looks good. @zentol's comments are nice-to-address issues. +1 to merge with addressing the comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1189#discussion_r40646129
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/util/ClusterUtil.java
---
@@ -26,11 +26,17 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-
-public class ClusterUtil {
+/**
+ * Utility class to manage mini cluster for Apache Flink.
+ */
+public final class ClusterUtil {
private static final Logger LOG =
LoggerFactory.getLogger(ClusterUtil.class);
+ private ClusterUtil() {
+ // Prevent instantiation.
--- End diff --
no javadoc, doesn't throw a runtime exception as other constructors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1189#discussion_r40646086 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ClassLoaderUtil.java --- @@ -129,4 +129,11 @@ public static boolean validateClassLoadable(ClassNotFoundException cnfe, ClassLo return false; } } + + /** +* No instantiation. --- End diff -- different javadoc compared to other private constructors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1189#discussion_r40645927
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/utils/ExampleUtils.java
---
@@ -117,7 +117,7 @@ public void configure(Configuration parameters) {
new FlatMapFunction>() {
@Override
public void flatMap(Long key,
- Collector> out)
+
Collector> out)
--- End diff --
formatting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2775] [CLEANUP] Cleanup code as part of...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1189#issuecomment-143916305 Looks like fail on unrelated Kafka partition error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
