[GitHub] flink pull request: [FLINK-2777] The description of programming_gu...

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1193


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2777] The description of programming_gu...

2015-09-29 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1193#issuecomment-144107560
  
Looks good, thank you!

Will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-2777] The description of programming_gu...

2015-09-29 Thread chenliang613
GitHub user chenliang613 opened a pull request:

https://github.com/apache/flink/pull/1193

[FLINK-2777] The description of programming_guide.html has some issues

def createLocalEnvironment(parallelism: Int = 
Runtime.getRuntime.availableProcessors())) 
//issue1: In the end, there is a extra ")" 

def createRemoteEnvironment(host: String, port: String, jarFiles: String*) 
def createRemoteEnvironment(host: String, port: String, parallelism: Int, 
jarFiles: String*) 
//issue2: the parameter of port should be "Int", not "String"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/flink patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1193


commit fa28ab0c8484e97e269d4e4aef26937277d52552
Author: Liang Chen 
Date:   2015-09-29T15:53:02Z

[FLINK-2777] The description of programming_guide.html has some issues

def createLocalEnvironment(parallelism: Int = 
Runtime.getRuntime.availableProcessors())) 
//issue1: In the end, there is a extra ")" 

def createRemoteEnvironment(host: String, port: String, jarFiles: String*) 
def createRemoteEnvironment(host: String, port: String, parallelism: Int, 
jarFiles: String*) 
//issue2: the parameter of port should be "Int", not "String"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---