[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/1268#issuecomment-149593562
  
Will merge this sometime today if no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1268#issuecomment-149338844
  
Thanks for fixing the documentation. The Java API offers also a variant 
that allows to specify a delimiter. It might be good to extend the signature of 
the Java method to have Scala and Java in sync. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[fhueske]

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/1268#discussion_r42422062
  
--- Diff: docs/apis/programming_guide.md ---
@@ -1721,7 +1721,8 @@ File-based:
   Returns a DataSet of tuples or POJOs. Supports the basic java types and 
their Value counterparts as field
   types.
 
-- `readFileOfPrimitives(path, Class)` / `PrimitiveInputFormat` - Parses 
files of new-line (or another char sequence) delimited primitive data types 
such as `String` or `Integer`. 
+- `readFileOfPrimitives(path, Class)` / `PrimitiveInputFormat` - Parses 
files of new-line (or another char sequence)
--- End diff --

Can you add the delimiter parameter to the Java version as well to have 
both APIs in sync?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[hsaputra]

GitHub user hsaputra opened a pull request:

https://github.com/apache/flink/pull/1268

[FLINK-2872] [Documentation] Update the documentation for Scala part to add 
ExecutionEnvironment.readFileOfPrimitives.

Add the missing Scala part for ExecutionEnvironment.readFileOfPrimitives 
API doc in the
programming guide.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hsaputra/flink 
add_readFileOfPrimitives_scala_guide

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1268


commit 1209019cfca6d1890c687818792eca568920af03
Author: Henry Saputra 
Date:   2015-10-19T19:06:49Z

[FLINK-2872] [Documentation] Update the documentation for Scala part to add 
readFileOfPrimitives.

Add the missing Scala part for ExecutionEnvironment.readFileOfPrimitives 
API doc in the
programming guide.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2872] [Documentation] Update the docume...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/1268#issuecomment-149372176
  
@fhueske , I have updated the PR with the Java variant info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---