[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1368#issuecomment-158328847
  
Will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-18 Thread mxm
Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1368#issuecomment-157752423
  
Very neat how you created a test JAR file with the custom InputFormat.

+1 for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1368#issuecomment-157384055
  
+1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-17 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/1368

[FLINK-3021] Fix class loading issue for streaming sources

Streaming sources were directly assigned their InputFormat in the 
StreamingJobGraphGenerator. As a consequence, the input formats were directly 
serialized/deserialized by Akka when the JobGraph was sent to the JobManager. 
In cases where the user provided a custom input format or an input format with 
custom types, this could lead to a ClassDefNotFoundException, because the 
system class loader instead of the user code class loader is used by Akka for 
the deserialization.

The problem was fixed by wrapping the InputFormat into a 
UserCodeObjectWrapper which is shipped ot the JobManager via the JobVertex's 
configuration. By instantiating stream sources as InputFormatVertices, the 
corresponding InputFormat is retrieved from the Configuration in the 
initializeOnMaster method call.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixInputFormatClassloading

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1368


commit d841654e392d5114cd2ce62bc47fb68ed8198a52
Author: Till Rohrmann 
Date:   2015-11-17T13:23:31Z

[FLINK-3021] Fix class loading issue for streaming sources

Streaming sources were directly assigned their InputFormat in the 
StreamingJobGraphGenerator. As a consequence, the input formats were directly 
serialized/deserialized by Akka when the JobGraph was sent to the JobManager. 
In cases where the user provided a custom input format or an input format with 
custom types, this could lead to a ClassDefNotFoundException, because the 
system class loader instead of the user code class loader is used by Akka for 
the deserialization.

The problem was fixed by wrapping the InputFormat into a 
UserCodeObjectWrapper which is shipped ot the JobManager via the JobVertex's 
configuration. By instantiating stream sources as InputFormatVertices, the 
corresponding InputFormat is retrieved from the Configuration in the 
initializeOnMaster method call.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---