[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1392#issuecomment-159747567 Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1392#issuecomment-159692006 Love it! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1392#issuecomment-159682996 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user jaoki commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45792220
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
/**
-* Writes a DataSet as a text file to the specified location.
-* For each element of the DataSet the result of {@link
Object#toString()} is written.
+* Writes a DataSet as text file(s) to the specified location.
+* For each element of the DataSet the result of {@link
Object#toString()} is written.
+*
+* How it writes DataSet
+* A single file is written when
+*
+* parallelism is set to 1
+* or https://ci.apache.org/projects/flink/flink-docs-master/setup/config.html#file-systems";>fs.output.always-create-directory
is set to true in flink-conf.yaml file
--- End diff --
@StephanEwen , good catch.
Let me clarify this further. We have 3 cases (instead of the current 2
cases)
1. /path1 as text file
2. /path1/1 and /path1/2 and so on
3. /path1/1 only. and 1 is a sole text file.
I mixed 1 and 3. will fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user jaoki commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45791866
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
/**
-* Writes a DataSet as a text file to the specified location.
-* For each element of the DataSet the result of {@link
Object#toString()} is written.
+* Writes a DataSet as text file(s) to the specified location.
+* For each element of the DataSet the result of {@link
Object#toString()} is written.
+*
+* How it writes DataSet
--- End diff --
will fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1392#issuecomment-158877137 Thanks for improving this. The docs were not obvious, and your change makes it much better. I added two comments, otherwise this looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45580248
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
/**
-* Writes a DataSet as a text file to the specified location.
-* For each element of the DataSet the result of {@link
Object#toString()} is written.
+* Writes a DataSet as text file(s) to the specified location.
+* For each element of the DataSet the result of {@link
Object#toString()} is written.
+*
+* How it writes DataSet
--- End diff --
Maybe call this "Output files and directories" or so...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45580214
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
/**
-* Writes a DataSet as a text file to the specified location.
-* For each element of the DataSet the result of {@link
Object#toString()} is written.
+* Writes a DataSet as text file(s) to the specified location.
+* For each element of the DataSet the result of {@link
Object#toString()} is written.
+*
+* How it writes DataSet
+* A single file is written when
+*
+* parallelism is set to 1
+* or https://ci.apache.org/projects/flink/flink-docs-master/setup/config.html#file-systems";>fs.output.always-create-directory
is set to true in flink-conf.yaml file
--- End diff --
This should probably mean "when it is set to `false`", no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1392 [FLINK-3059] Javadoc fix for DataSet.writeAsText() Currently writeAsText() in javadoc states it simply generates a file, but this is not always true and it depends on the environment configuration. This Pull Request is to add the clarification to the method's javadoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaoki/flink descirption-for-writeAsText Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1392 commit ef5894e448a918df9e05b861aa085ef1e5fb Author: jaoki Date: 2015-11-23T03:18:57Z [FLINK-3059] Javadoc fix for DataSet.writeAsText() Currently writeAsText() in javadoc states it simply generates a file, but this is not always true and it depends on the environment configuration. This Pull Request is to add the clarification to the method's javadoc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
