[GitHub] flink pull request: [FLINK-3459] [build] Fix conflicting dependenc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1682


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3459] [build] Fix conflicting dependenc...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1682#issuecomment-187604538
  
Thanks for the review @rmetzger, @chiwanpark. Will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3459] [build] Fix conflicting dependenc...

[chiwanpark]

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1682#issuecomment-187148301
  
Tested on vanila Hadoop 2.7.2:

 - Flink cluster is started successfully.
 - WordCount example is working.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3459] [build] Fix conflicting dependenc...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1682#issuecomment-187125611
  
I tested this change and #1681 on a HDP cluster and Flink started 
successfully on YARN.
I know that this one test is certainly not sufficient to guarantee that it 
works on all Hadoop distributions.

+1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3459] [build] Fix conflicting dependenc...

[tillrohrmann]

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/1682

[FLINK-3459] [build] Fix conflicting dependencies commons-collections 
commons-beanutils and commons-beanutils-core

The Hadoop dependencies have a dependency on commons-configuration which 
pulls in transitively the commons-collection, commons-beanutils and 
common-beanutils-core depedencies. Commons-beanutils and commons-collection 
contain classes which live in the same namespace. They are also binary 
compatible but not binary identical. This is a problem for the sbt assembly 
plugin which checks for binary identity. In order to solve the problem, we bump 
the commons-configuration version to 1.7 so that only commons-beanutils is 
pulled in. This is necessary, because the transitive promotion of dependencies 
of the shade plugin only excludes the commons-beanutils dependency only from 
the directly depending dependency. All parent dependencies won't have the 
exclusion. This is a problem for SBT which will pull the dependency as part of 
one of the parents, then. Moreover, we replace commons-beanutils by 
commons-beanutils-bean-collections which contains only the non-conflicting 
classes wrt commons-col
 lections.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink makeSbtCompatible

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1682


commit 872a5cc8b40142feb6313549e1ed2b2029ce4d68
Author: Till Rohrmann 
Date:   2016-02-17T14:41:43Z

[FLINK-3459] [build] Fix conflicting dependencies commons-collections, 
commons-beanutils and commons-beanutils-core

The Hadoop dependencies have a dependency on commons-configuration which 
pulls in transitively the commons-collection, commons-beanutils and 
common-beanutils-core depedencies. Commons-beanutils and commons-collection 
contain classes which live in the same namespace. They are also binary 
compatible but not binary identical. This is a problem for the sbt assembly 
plugin which checks for binary identity. In order to solve the problem, we bump 
the commons-configuration version to 1.7 so that only commons-beanutils is 
pulled in. This is necessary, because the transitive promotion of dependencies 
of the shade plugin only excludes the commons-beanutils dependency only from 
the directly depending dependency. All parent dependencies won't have the 
exclusion. This is a problem for SBT which will pull the dependency as part of 
one of the parents, then. Moreover, we replace commons-beanutils by 
commons-beanutils-bean-collections which contains only the non-conflicting 
classes wrt commons-col
 lections.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---