[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1914


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214299635
  
I've addressed the problem of the failing test cases by introducing a CLI 
option to specify the configuration directory. That way, we can also set a 
valid configuration directory for the test cases. Once Travis gives green 
light, I would merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214278457
  
They should work independently of #1904. I have to check why the tests fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[zentol]

Github user zentol commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214263164
  
I'm asking since the scala shell tests fail both in travis and locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[zentol]

Github user zentol commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214262824
  
Does this commit only work in combination with #1904?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[zentol]

Github user zentol commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214246701
  
Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1914#issuecomment-214224340
  
Good catch! +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

[tillrohrmann]

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/1914

[FLINK-3775] [shell] Load Flink configuration before forwarding it

This commit makes sure that the GlobalConfiguration is loaded before the 
FlinkShell
is started.

- [X] General
  - The pull request references the related JIRA issue
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message

- [X] Tests
  - Has been tested on YARN cluster in combination with #1904 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixScalaShellYarn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1914


commit 2284a1bd172dcc91b66d558de8a5e8fff67d1651
Author: Till Rohrmann 
Date:   2016-04-19T13:04:37Z

[FLINK-3775] [shell] Load Flink configuration before forwarding it

This commit makes sure that the GlobalConfiguration is loaded before the 
FlinkShell
is started.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---