[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2010


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[aljoscha]

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/2010#discussion_r63869803
  
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -142,18 +142,24 @@ for querying the list of topics and partitions.
 For this to work, the consumer needs to be able to access the consumers 
from the machine submitting the job to the Flink cluster.
 If you experience any issues with the Kafka consumer on the client side, 
the client log might contain information about failed requests, etc.
 
-# The `DeserializationSchema`
+# **The `DeserializationSchema`**
--- End diff --

`kafka.md` uses very low level headings. The batch and streaming guides use 
level 2 headings for top-level headings while `kafka.md` uses level 4. I think 
the solution is to reduce heading level by 2 on all levels in this document, 
which would yield
```
### The `DeserializationSchema`
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/2010#discussion_r63868527
  
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -142,18 +142,24 @@ for querying the list of topics and partitions.
 For this to work, the consumer needs to be able to access the consumers 
from the machine submitting the job to the Flink cluster.
 If you experience any issues with the Kafka consumer on the client side, 
the client log might contain information about failed requests, etc.
 
-# The `DeserializationSchema`
+# **The `DeserializationSchema`**
--- End diff --

The whole doc uses pretty low weight formatting. It is hard to recognize a 
heading as such. I overlooked the section initially.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/2010#issuecomment-220293427
  
Good addition that simplifies user's lives, I just saw someone on stack 
overflow who was struggling with how to get the `TypeInformation` for 
`getOutputType`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/2010#issuecomment-220293226
  
LGTM except for a minor comment in the doc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[aljoscha]

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/2010#discussion_r63859068
  
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -142,18 +142,24 @@ for querying the list of topics and partitions.
 For this to work, the consumer needs to be able to access the consumers 
from the machine submitting the job to the Flink cluster.
 If you experience any issues with the Kafka consumer on the client side, 
the client log might contain information about failed requests, etc.
 
-# The `DeserializationSchema`
+# **The `DeserializationSchema`**
--- End diff --

Why did you add the `**`? The other section headings don't have it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3933] [streaming API] Add AbstractDeser...

[StephanEwen]

GitHub user StephanEwen opened a pull request:

https://github.com/apache/flink/pull/2010

[FLINK-3933] [streaming API] Add AbstractDeserializationSchema

This PR adds an `AbstractDeserializationSchema` that handles the produced 
type extraction automatically from the generic types via the TypeExtractor 
(reflection)

Also adds test and documentation, references the new 
`AbstractDeserializationSchema` in the docs of the `DeserializationSchema`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StephanEwen/incubator-flink abstract_schema

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2010


commit 24e9f833a4ce4004b861c07772aa842e4169577b
Author: Stephan Ewen 
Date:   2016-05-19T10:37:05Z

[FLINK-3933] [streaming API] Add AbstractDeserializationSchema that handles 
produced type extraction.

The AbstractDeserializationSchema creates the produced type information 
automatically from the
generic parameters.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---