[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/735


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread twalthr
Github user twalthr commented on the pull request:

https://github.com/apache/flink/pull/735#issuecomment-105913011
  
I will create an issue and assign it to me. I think I will heavily work on 
the Table API anyway the next time ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/735#issuecomment-105910200
  
I thought we have ITCases for our examples to ensure that they are working?
Maybe we should add those to these examples as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/735#issuecomment-105910800
  
Sorry for the rude comment. Thank you for fixing the issue. Very good catch 
;)
Maybe we should file a JIRA for adding ITCases for these examples ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [hotfix] Remove execute() after print() in Tab...

2015-05-27 Thread twalthr
GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/735

[hotfix] Remove execute() after print() in Table API examples



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink tableApiExampleFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit e43cf3f7d92dc4e9d80850e3a80501c4a6e3773e
Author: twalthr twal...@apache.org
Date:   2015-05-27T13:32:11Z

[hotfix] Remove execute() after print() in Table API examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---