[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134592174 Corresponding issue in order to track fixed issues for the upcoming release: https://issues.apache.org/jira/browse/FLINK-2572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134525059 OK, can you please update the PR accordingly? I will test it and then we are good to go. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134554634 Here you go. Thanks for testing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1049 [scripts] resolve base path of symlinked executable This bootstraps Flink from a symlinked bin/flink executable. It's a special case but IMHO worthwhile to consider. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink symlink-startup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1049.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1049 commit e4ba6459cad193ea7103d7f7f47825e8f25065af Author: Maximilian Michels m...@apache.org Date: 2015-08-24T12:40:47Z [scripts] resolve base path of symlinked executable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134192838 Unfortunately, we cannot access the config.sh file in this case. So code reuse is not possible. I've also seen the code you posted. It looks awfully hacky and we could at least use my code snippet also in the `scripts.sh`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134198322 Yes, we cannot access it. I meant to either copy from `config.sh` or Your New Snippet⢠to have it in sync. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134189431 We have similar code in `config.sh`: ```bash # Resolve links this=$0 while [ -h $this ]; do ls=`ls -ld $this` link=`expr $ls : '.*- \(.*\)$'` if expr $link : '.*/.*' /dev/null; then this=$link else this=`dirname $this`/$link fi done ``` Does it make sense to have both scripts in sync as they try to do the same thing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134230260 Yes, the two are in sync now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [scripts] resolve base path of symlinked execu...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1049#issuecomment-134298584 Apparently, the `readlink` utility is not part of POSIX. So we might have to revert to the old way of parsing the output of `ls -ld` to stay compatible. It is actually more reliable than I thought because POSIX specifies that the output of `ls -ld` should always be of the form link_name - target. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
