[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-141413305 ok, I'm merging it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-141399006 I like this, feels more intuitive to me and makes sense that a task either implements all of the methods, ot none... +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-139238695 I rebased it and consolidated the state related interfaces into one interface. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-138923637 I actually like this. Can you rebase to master, and maybe change one name: `CheckpointCommittingTask` --> `CheckpointCompleteNotifiyee` or `CheckpointCompleteNotificationReceiver` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/671#issuecomment-138898146
It's still valid, I think the names are still off
```
public abstract class StreamTask>
extends AbstractInvokable implements
OperatorStateCarrier>,
CheckpointedOperator, CheckpointNotificationOperator {
```
The StreamTask implements interfaces that have Operator in their names, and
they are inconsistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-138890373 @aljoscha, is this PR still valid after the recent refactoring and extension of the streaming state interfaces? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-109936539 No problemo :smile: It's only internal, though, now user-facing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-109933236 Sorry, I thought we had this mostly in already. My bad. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-109932208 Why? There is still a naming difference between methods that to similar things at different levels. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-109926187 I think this is redundant now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-101654445 Nah, you can change it of course. :smile_cat: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-101653784 It would mean "the state with which that operator instance is started". It is just a personal preference - just keep it as it is if you want... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-101652722 But what does restoreInitialState mean? What is the initial state? The state when the operator was first created? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/671#issuecomment-101651301 Looks good I actually liked the function name `restoreInitialState`. This makes it very clear that this method sets only the initial state, not any state whensoever. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Clean up naming of State/Checkpoint Interfaces
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/671 Clean up naming of State/Checkpoint Interfaces The interfaces are used on StreamTask (for now) but were called *Operator. Also, the methods on operator were suggesting that it is only user function state while it could also be state of a stateful system operator such as a windowing operator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink state-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/671.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #671 commit 0c7e9ec56614ce1662193d23041ba457d13ba74b Author: Aljoscha Krettek Date: 2015-05-13T10:15:28Z Clean up naming of State/Checkpoint Interfaces The interfaces are used on StreamTask (for now) but were called *Operator. Also, the methods on operator were suggesting that it is only user function state while it could also be state of a stateful system operator such as a windowing operator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
