GitHub user Fokko opened a pull request:
https://github.com/apache/flink/pull/3081
[FLINK-5426] Clean up the Flink Machine Learning library
Hi guys,
I would like to contribute to the Flink ML library. I took the liberty to
clean up some of the code and improve the scaladoc. Beside that I've
implemented #3077 to get more familiar with the Flink API and I would love to
contribute more in the future, in particular the machine learning library.
If you have any questions, please let me know. Let me know if improvements
to the ML library are appreciated in general.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fokko/flink fd-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3081
commit 013b22d7bcaf48c8e96983295fcc455faf0aa94b
Author: Fokko Driesprong
Date: 2017-01-06T20:34:53Z
Removed duplicate tests, inproved scaladoc and naming, removed typo's in
scaladoc, introduced and improved use of constants, improved test-case naming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
