[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4544 ---
[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4544#discussion_r151128673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -269,6 +272,10 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) extends JavaTypeFactoryImp canonize(newType) } + + override def getDefaultCharset: Charset = { +Charset.forName(ConversionUtil.NATIVE_UTF16_CHARSET_NAME) --- End diff -- Calcite only supports UTF-16, I guess because this is the default of Java Strings anyway. ---
[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4544#discussion_r140717599 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -269,6 +272,10 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) extends JavaTypeFactoryImp canonize(newType) } + + override def getDefaultCharset: Charset = { +Charset.forName(ConversionUtil.NATIVE_UTF16_CHARSET_NAME) --- End diff -- +1 doesn't having UTF-8 everywhere solve all problems? ---
[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4544#discussion_r140703450 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -269,6 +272,10 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) extends JavaTypeFactoryImp canonize(newType) } + + override def getDefaultCharset: Charset = { +Charset.forName(ConversionUtil.NATIVE_UTF16_CHARSET_NAME) --- End diff -- Should we do UTF-8 by default? You can just use `java.nio.charset.StandardCharsets.UTF_8` to avoid introducing additional dependency. ---
[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4544 [FLINK-7451] [table] Support non-ascii character literals in Table API and SQL ## What is the purpose of the change The non-ascii characters in string literals causes calcite planner to throw the following exception: ``` Failed to encode '%æµè¯%' in character set 'ISO-8859-1' ``` ## Brief change log - add default charset for FlinkTypeFactory ## Verifying this change This change added tests and can be verified as follows: - Added expression test for non-ascii literals ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? na You can merge this pull request into a Git repository by running: $ git pull https://github.com/wuchong/flink non-ascii Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4544.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4544 commit 6013d2693a4eb3622dc1cbb7d27829ee5b566713 Author: Jark Wu Date: 2017-08-15T11:24:57Z [FLINK-7451] [table] Support non-ascii character literals in Table API and SQL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---