[GitHub] flink pull request #5019: [FLINK-7942] [table] Reduce aliasing in RexNodes

2017-11-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5019


---

[GitHub] flink pull request #5019: [FLINK-7942] [table] Reduce aliasing in RexNodes

2017-11-15 Thread fhueske 
Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/5019#discussion_r151110174
  
--- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/OverWindowTest.scala
 ---
@@ -203,19 +203,17 @@ class OverWindowTest extends TableTestBase {
 "DataStreamCalc",
 unaryNode(
   "DataStreamOverAggregate",
-  unaryNode(
-"DataStreamCalc",
-streamTableNode(0),
-term("select", "a", "c", "proctime")
-  ),
+  streamTableNode(0),
--- End diff --

The new plan is less efficient, because a projection isn't pushed down 
anymore and a wider row needs to be materialized in the over window.


---

[GitHub] flink pull request #5019: [FLINK-7942] [table] Reduce aliasing in RexNodes

2017-11-15 Thread twalthr 
GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/5019

[FLINK-7942] [table] Reduce aliasing in RexNodes

## What is the purpose of the change

This PR reduces the number of `AS` expressions in projects. This fixes the 
bug mentioned in FLINK-7942 with the `FilterJoinRule` and improves the plans. 
Many calc operations are not needed anymore. For multi-windows, the change 
caused some problems that are not trivial to fix, so they still use aliasing 
for resolving time attributes.

## Brief change log

- Remove explicit alias expression from RexNodes


## Verifying this change

- Added testFilterJoinRule in JoinTest.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): no
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation

  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-7942

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5019


commit 82356f22154c563fcd8bd018dd954fe274e7fe5f
Author: twalthr 
Date:   2017-11-15T11:07:16Z

[FLINK-7942] [table] Reduce aliasing in RexNodes




---