[GitHub] flink pull request #5135: [hotfix] [doc] Fix typo in TaskManager and Environ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5135 ---
[GitHub] flink pull request #5135: [hotfix] [doc] Fix typo in TaskManager and Environ...
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5135#discussion_r155627163 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -585,7 +585,7 @@ class TaskManager( config.getMaxRegistrationPause().toMilliseconds, TimeUnit.MILLISECONDS)) -// schedule (with our timeout s delay) a check triggers a new registration +// schedule (with our timeout's delay) a check triggers a new registration --- End diff -- "triggers" -> "to trigger"? Or rewrite like "schedule a check to trigger a new registration attempt if not registered by the timeout"? ---
[GitHub] flink pull request #5135: [hotfix] [doc] Fix typo in TaskManager and Environ...
GitHub user casidiablo opened a pull request: https://github.com/apache/flink/pull/5135 [hotfix] [doc] Fix typo in TaskManager and EnvironmentInformation doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/casidiablo/flink hotfix/comments-typo-tm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5135 commit 9f59d9bd9dea0f95aed788c1b2a5a20a995ca07c Author: Cristian Date: 2017-12-07T19:00:00Z [hotfix] [doc] Fix typo in TaskManager and EnvironmentInformation doc ---