[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

[shuai-xu]

Github user shuai-xu closed the pull request at:

https://github.com/apache/flink/pull/5190


---

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

[shuai-xu]

Github user shuai-xu commented on a diff in the pull request:

https://github.com/apache/flink/pull/5190#discussion_r158627004
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ---
@@ -155,6 +156,7 @@ protected void runCluster(Configuration configuration) 
throws Exception {
// write host information into configuration
configuration.setString(JobManagerOptions.ADDRESS, 
commonRpcService.getAddress());
configuration.setInteger(JobManagerOptions.PORT, 
commonRpcService.getPort());
+   configuration.setString(RestOptions.REST_ADDRESS, 
commonRpcService.getAddress());
--- End diff --

I think what we want to get from the RestServerEndpoint is its server 
address. One way is to let its bind address to be the real ip of the machine. 
The common rpc address now is the real ip. 


---

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

[EronWright]

Github user EronWright commented on a diff in the pull request:

https://github.com/apache/flink/pull/5190#discussion_r158545462
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ---
@@ -155,6 +156,7 @@ protected void runCluster(Configuration configuration) 
throws Exception {
// write host information into configuration
configuration.setString(JobManagerOptions.ADDRESS, 
commonRpcService.getAddress());
configuration.setInteger(JobManagerOptions.PORT, 
commonRpcService.getPort());
+   configuration.setString(RestOptions.REST_ADDRESS, 
commonRpcService.getAddress());
--- End diff --

This appears to be configuring the REST server's bind address, using the 
server address obtained from `AkkaRpcService`.   I don't understand the 
rationale, could you explain?


---

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

[shuai-xu]

GitHub user shuai-xu opened a pull request:

https://github.com/apache/flink/pull/5190

[FLINK-8289] [runtime] set the rest.address to the host of the rest server 
machine


## What is the purpose of the change

This pull request set the rest.address to the host of the Dispatcher or 
JobMaster, so that the real address of the rest server instead of 0.0.0.0:9067 
or 127.0.0.0:9067.



## Verifying this change

This change is tested manually.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shuai-xu/flink jira-8289

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5190


commit 0956b94a910df071a61aae90cac7fef2b795ed0c
Author: shuai.xus 
Date:   2017-12-20T09:37:10Z

[FLINK-8289] [runtime] set the rest.address to the host of the rest server 
machine




---