[GitHub] flink pull request #6219: [hotfix] Fixed typo in docs

2018-06-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6219


---

[GitHub] flink pull request #6219: [hotfix] Fixed typo in docs

2018-06-30 Thread tillrohrmann 
Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/6219#discussion_r199332279
  
--- Diff: docs/monitoring/metrics.md ---
@@ -426,7 +426,7 @@ class MyMapper extends RichMapFunction[Long,Long] {
 
 Every metric is assigned an identifier and a set of key-value pairs under 
which the metric will be reported.
 
-THe identifier is based on 3 components: the user-defined name when 
registering the metric, an optional user-defined scope and a system-provided 
scope.
+The identifier is based on 3 components: the user-defined name when 
registering the metric, an optional user-defined scope and a system-provided 
scope.
--- End diff --

I think you are right @yanghua. Will change it will merging this PR.


---

[GitHub] flink pull request #6219: [hotfix] Fixed typo in docs

2018-06-30 Thread yanghua 
Github user yanghua commented on a diff in the pull request:

https://github.com/apache/flink/pull/6219#discussion_r199316517
  
--- Diff: docs/monitoring/metrics.md ---
@@ -426,7 +426,7 @@ class MyMapper extends RichMapFunction[Long,Long] {
 
 Every metric is assigned an identifier and a set of key-value pairs under 
which the metric will be reported.
 
-THe identifier is based on 3 components: the user-defined name when 
registering the metric, an optional user-defined scope and a system-provided 
scope.
+The identifier is based on 3 components: the user-defined name when 
registering the metric, an optional user-defined scope and a system-provided 
scope.
--- End diff --

@elbaulp I think use "a user-defined name" to replace "the user-defined 
name" would be better, what's your opinion? @tillrohrmann 


---

[GitHub] flink pull request #6219: [hotfix] Fixed typo in docs

2018-06-27 Thread elbaulp 
GitHub user elbaulp opened a pull request:

https://github.com/apache/flink/pull/6219

[hotfix] Fixed typo in docs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elbaulp/flink patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6219


commit ab3f846772e6e5114b19a79bcc91dccf9b012151
Author: Alejandro Alcalde 
Date:   2018-06-27T16:17:54Z

[hotfix] Fixed typo in docs




---