[GitHub] kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator.
kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator. URL: https://github.com/apache/flink/pull/6871#issuecomment-441673911 Thanks @twalthr ! So I will rebase the PR and have another look and if travis gives green light, I will go on and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator.
kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator. URL: https://github.com/apache/flink/pull/6871#issuecomment-441642893 @fhueske @twalthr @pnowojski What should we do with this PR given the effort to remove scala from sql's runtime code? Should I re-write it in Java? In addition, does this overlap with the effort to finalise TTL support at the backend level? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator.
kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator. URL: https://github.com/apache/flink/pull/6871#issuecomment-431040705 done! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator.
kl0u commented on issue #6871: [FLINK-10583][table] Add base TwoInputStreamOperator with TTL operator. URL: https://github.com/apache/flink/pull/6871#issuecomment-431026956 @pnowojski I integrated your comments. Let me know what you think. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
