[GitHub] tillrohrmann commented on issue #6716: [hotfix] [yarn-test] Clean up inactive test
tillrohrmann commented on issue #6716: [hotfix] [yarn-test] Clean up inactive test URL: https://github.com/apache/flink/pull/6716#issuecomment-423083471 @TisonKun I'm not sure whether we can already remove the `TestingYarnClusterDescriptor` because it is still being used by the `YARNHighAvailabilityITCase`. Only after we have removed the legacy mode, we should remove these tests. Otherwise we risk to run into regressions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6716: [hotfix] [yarn-test] Clean up inactive test
tillrohrmann commented on issue #6716: [hotfix] [yarn-test] Clean up inactive test URL: https://github.com/apache/flink/pull/6716#issuecomment-422798581 Thanks for opening this PR @TisonKun. The `YarnITCase` is actually not using the legacy mode but the Flip-6 code path. Instead of removing it, I think we should activate it. I tried to see what's missing and it seems to work by adding the following changes: #6717. Therefore I would suggest to rather activate the test instead of removing it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
