[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-452648321 Thanks for the reminder @TisonKun. Merging this PR since we concluded the discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-436985378 Thanks for the reminder @TisonKun. I'll get back to that once the release is out, because I'm the release manager. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-435079003 I think this fix will go into the master once we have cut the release branch for 1.7. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431287759 I could imagine a custom HTTP client used to query the REST endpoint which relies on `RestOptions#ADDRESS`. Admittedly, the `RestOptions` are marked as `@Internal` though. Yes, at some point I guess we have to break the behaviour. However, I think we are derailing the discussion a bit and widening the scope of this issue. The issue is intended to solve the problem that we log warnings when falling back to the `JobManagerOptions#ADDRESS`. The dependency of `RestOptions#ADDRESS` on `JobManagerOptions#ADDRESS` is not intended to be resolved in the scope of this issue. I think the changes of this PR do not make things worse and indeed solve the problem of deprecation warnings. Consequently, I would suggest that we address the disentanglement in a separate issue. What do you think @zentol? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431093823 At the moment `rest.address` is effectively `dispatcher.rest.address`. The problem I see currently is that other components might already depend on `RestOption#ADDRESS`. If we now introduce a `RestOption#DISPATCHER_ADDRESS` with the fallback to `RestOption#ADDRESS` and `JobManagerOptions#ADDRESS` and remove the latter as a deprecated key from the former, then we break setups. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431055291 The idea is that some options can default to some other option if they are not specified but the other option. Here concretely, it is the `rest.address` which is the same as the `jobmanager.rpc.address`. This of course only makes sense in the current setup, where the `RestServerEndpoint` runs in the same process as the `Dispatcher`. In the future, this might change and could require to remove the fallback dependency depending on what the default behaviour is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
