[GitHub] zentol commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop
zentol commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop URL: https://github.com/apache/flink/pull/6663#issuecomment-425908812 The build files wouldn't be really be simpler; we will still need a jdk9 profile regardless. I've found too many threads on google where users had issues which could be resolved by adding the `jdk.tools` dependency to consider this a 100% safe change. Since the degree of simplification is questionable and there are otherwise no benefits to generally excluding the dependency the risks far exceed the rewards. If even a single person is inconvenienced by this it already wasn't worth it. I will merge the PR as is. Let's move the discussion for moving hadoop to `flink-shaded` into a dedicated JIRA since it will just get lost here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop
zentol commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop URL: https://github.com/apache/flink/pull/6663#issuecomment-423906315 Echoing my response from the JIRA: > Travis is passing even if we exclude the dependency in general. However I'm not really comfortable with making this change for jdk8 builds since I don't really know about possible repercussions in different environments. Moving hadoop to flink-shaded will make it more difficult for users to run hadoop versions that we do not provide directly. This will also help very little in regards to dependency convergence as it is unlikely we will find a setup where all dependencies are converged for different hadoop versions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
