[GitHub] zentol commented on issue #6899: [FLINK-10637] Use MiniClusterResource for tests in flink-runtime

2018-10-23 Thread GitBox
zentol commented on issue #6899: [FLINK-10637] Use MiniClusterResource for 
tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#issuecomment-432301818
 
 
   sounds good to me @tillrohrmann .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zentol commented on issue #6899: [FLINK-10637] Use MiniClusterResource for tests in flink-runtime

2018-10-23 Thread GitBox
zentol commented on issue #6899: [FLINK-10637] Use MiniClusterResource for 
tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#issuecomment-432233195
 
 
   hold on, I'm wondering about one thing: Do we really want to change the 
package? It's not _unlikely_ that there are users out there relying on the 
`MiniClusterResource`, we've regularly point users toward that class for 
testing purposes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services