[GitHub] zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation
zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation URL: https://github.com/apache/flink/pull/7291#discussion_r241819796 ## File path: docs/dev/table/connect.md ## @@ -58,11 +56,7 @@ The following table list all available connectors and formats. Their mutual comp | JSON | `flink-json` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-json/{{site.version}}/flink-json-{{site.version}}-sql-jar.jar) | | Apache Avro | `flink-avro` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-avro/{{site.version}}/flink-avro-{{site.version}}-sql-jar.jar) | -{% else %} - -This table is only available for stable releases. - -{% endif %} Review comment: @twalthr I have recovered the changes, can you help me to have a review, thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation
zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation URL: https://github.com/apache/flink/pull/7291#discussion_r241627373 ## File path: docs/dev/table/connect.md ## @@ -58,11 +56,7 @@ The following table list all available connectors and formats. Their mutual comp | JSON | `flink-json` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-json/{{site.version}}/flink-json-{{site.version}}-sql-jar.jar) | | Apache Avro | `flink-avro` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-avro/{{site.version}}/flink-avro-{{site.version}}-sql-jar.jar) | -{% else %} - -This table is only available for stable releases. - -{% endif %} Review comment: @klion26 Thank you for your review. As shown in the `Dependencies` module of [Connect to External Systems](https://ci.apache.org/projects/flink/flink-docs-master/dev/table/connect.html) page, `Connectors` and `Formats` tables are described, but we cannot see theses tables, which is confusing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation
zzchun commented on a change in pull request #7291: [hotfix] [docs] Display Connectors and Formats tables, and fix typo in documentation URL: https://github.com/apache/flink/pull/7291#discussion_r241627373 ## File path: docs/dev/table/connect.md ## @@ -58,11 +56,7 @@ The following table list all available connectors and formats. Their mutual comp | JSON | `flink-json` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-json/{{site.version}}/flink-json-{{site.version}}-sql-jar.jar) | | Apache Avro | `flink-avro` | [Download](http://central.maven.org/maven2/org/apache/flink/flink-avro/{{site.version}}/flink-avro-{{site.version}}-sql-jar.jar) | -{% else %} - -This table is only available for stable releases. - -{% endif %} Review comment: As shown in the `Dependencies` module of [Connect to External Systems](https://ci.apache.org/projects/flink/flink-docs-master/dev/table/connect.html) page, `Connectors` and `Formats` tables are described, but we cannot see theses tables, which is confusing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services