Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin merged PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
boring-cyborg[bot] commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1847843835 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1847841688 weekly passed https://github.com/snuyanzin/flink-connector-hive/actions/runs/7145518824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1847626718 After merging of mentioned PRs to [flink-connector-shared-utils](https://github.com/apache/flink-connector-shared-utils) all related WAs are removed and `ci_utils` is reused. Also there are a couple of commits to hive connector in main repo, one of which leaded to conflicts. Now they are integrated here as well The PR also enables manual trigger of nightly however it will be possible to trigger this only after merge to main I will trigger it on my own fork I'm going to merge it soon after the build is green and nightly on my fork is also green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846779031 > dedicated ML thread for that or since there is already existing jira issue for Hive externalisation, we could just continue with it? It would be good to announce the intent at least, to also avoid that Hive commits get merged into `master` between the time the release (which we should make indeed) is completed and the externalization happening -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846772791 >I'm reviewing the CI PRs; when they are merged and we can merge this thanks a lot for your review > will we remove the Hive code from Flink's master branch? yes, that was the plan, the only question is whether we need a dedicated ML thread for that or since there is already existing jira issue for Hive externalisation, we could just continue with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846754733 > please let me know whether you are ok with this or not I'm reviewing the CI PRs; when they are merged and we can merge this, will we remove the Hive code from Flink's `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846421674 @snuyanzin Cool! Thanks for your work. It sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846072081 Currently it works for hive2 and hive3 (without e2e for jdk11) as |hive version |flink 1.18 + jdk 8 | flink 1.19-snapshot + jdk8 | flink 1.18 + jdk 11 | flink 1.19-snapshot + jdk11 | |--|:-:|--:|--:|-:| | 2 | ✅ | ✅ |✅ |✅ | |3 | ✅ |✅ | no E2E | no E2E| as mentioned above under flink main there is no E2E tests for jdk11 as well The PR currently copies `ci.yaml` from [flink-connector-shared-utils](https://github.com/apache/flink-connector-shared-utils) ... at the same side there are 2 PRs for that repo to support customization of jdk version https://github.com/apache/flink-connector-shared-utils/pull/24 and maven profiles https://github.com/apache/flink-connector-shared-utils/pull/29 , these 2 features are used here. Once they are merged `ci.yml` could be reused and the copy could be removed @luoyuxia , @MartijnVisser please let me know whether you are ok with this or not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845395649 just another note, I noticed that hive3 is tested only for jdk8 in flink nightlies I tried to run it with jdk 11 and e2e failed while for hive2 it is passing Since it was not run with jdk11 i will add support only for jdk8 for hive3 as it is done in flink main repo other jdk support could be done separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845350918 yep, that exactly the idea i'm testing right now =) thanks for confirmation :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845282371 > I will see if it could be supported on a generic way since same functionality would be nice to have for OpenSearch connector We could consider adding `optional_maven_profiles` as a generic variable and pass that through (kind of like https://github.com/apache/flink-connector-shared-utils/blob/ci_utils/.github/workflows/ci.yml#L87-L89) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845250800 > I want to make sure we can have a chance to test & verify it with hive3. Good point. I actually think we should consider running them both for each PR, that should be easier with Hive being externalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1843773243 > Will we adjust them in the pr of removing Hive connector from flink repo? yep, usually it's happening either with while removal of connector from main repo or together with the first oficial release of externalised connector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-hive/pull/5#discussion_r1418033313
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java:
##
@@ -0,0 +1,1000 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+import org.apache.flink.FlinkVersion;
+import org.apache.flink.api.common.restartstrategy.RestartStrategies;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.connector.file.table.FileSystemConnectorOptions;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.util.FiniteTestSource;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.ExplainDetail;
+import org.apache.flink.table.api.Expressions;
+import org.apache.flink.table.api.Schema;
+import org.apache.flink.table.api.SqlDialect;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.table.catalog.CatalogPartitionSpec;
+import org.apache.flink.table.catalog.ObjectPath;
+import org.apache.flink.table.catalog.hive.HiveCatalog;
+import org.apache.flink.table.catalog.hive.HiveTestUtils;
+import org.apache.flink.table.catalog.stats.CatalogTableStatistics;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+import org.apache.flink.util.CollectionUtil;
+import org.apache.flink.util.TestLoggerExtension;
+
+import org.apache.flink.shaded.guava31.com.google.common.collect.Lists;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Consumer;
+
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_TIMESTAMP_PATTERN;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_DELAY;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_CLASS;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_KIND;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_SUCCESS_FILE_NAME;
+import static org.apache.flink.table.api.Expressions.$;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.readFromResource;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceNodeIdInOperator;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceStageId;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceStreamNodeId;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests {@link HiveTableSink}. */
+@ExtendWith(TestLoggerExtension.class)
+class HiveTableSinkITCase {
+
+private static HiveCatalog hiveCatalog;
+
+@BeforeAll
+static void createCatalog() {
+hiveCatalog = HiveTestUtils.createHiveCatalog();
+hiveCatalog.open();
+}
+
+@AfterAll
+static void closeCatalog() {
+if (hiveCatalog != null) {
+hiveCatalog.close();
+}
+}
+
+@Test
+void testHiveTableSinkWithParallelismInBatch() throws Exception {
+final Tabl
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1842010718 @snuyanzin Hi, I also found some pages(https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/hive-compatibility/hive-dialect/overview/ , https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sql-gateway/hiveserver2/) in Flink still refer to Hive with internal link. Will we adjust them in the pr of removing Hive connector from flink repo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
luoyuxia commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-hive/pull/5#discussion_r1416565534
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java:
##
@@ -0,0 +1,1000 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+import org.apache.flink.FlinkVersion;
+import org.apache.flink.api.common.restartstrategy.RestartStrategies;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.connector.file.table.FileSystemConnectorOptions;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.util.FiniteTestSource;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.ExplainDetail;
+import org.apache.flink.table.api.Expressions;
+import org.apache.flink.table.api.Schema;
+import org.apache.flink.table.api.SqlDialect;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.table.catalog.CatalogPartitionSpec;
+import org.apache.flink.table.catalog.ObjectPath;
+import org.apache.flink.table.catalog.hive.HiveCatalog;
+import org.apache.flink.table.catalog.hive.HiveTestUtils;
+import org.apache.flink.table.catalog.stats.CatalogTableStatistics;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+import org.apache.flink.util.CollectionUtil;
+import org.apache.flink.util.TestLoggerExtension;
+
+import org.apache.flink.shaded.guava31.com.google.common.collect.Lists;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Consumer;
+
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_TIMESTAMP_PATTERN;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_DELAY;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_CLASS;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_KIND;
+import static
org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_SUCCESS_FILE_NAME;
+import static org.apache.flink.table.api.Expressions.$;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.readFromResource;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceNodeIdInOperator;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceStageId;
+import static
org.apache.flink.table.planner.utils.TableTestUtil.replaceStreamNodeId;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests {@link HiveTableSink}. */
+@ExtendWith(TestLoggerExtension.class)
+class HiveTableSinkITCase {
+
+private static HiveCatalog hiveCatalog;
+
+@BeforeAll
+static void createCatalog() {
+hiveCatalog = HiveTestUtils.createHiveCatalog();
+hiveCatalog.open();
+}
+
+@AfterAll
+static void closeCatalog() {
+if (hiveCatalog != null) {
+hiveCatalog.close();
+}
+}
+
+@Test
+void testHiveTableSinkWithParallelismInBatch() throws Exception {
+final Table
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1837569300 rebased since there were new commits in main flink master to hive-connector area also added archunit violations because of reent commit within FLINK-33637 @RyanSkraba moved test packages to `flink.connectors.hive` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1837025511 Cool! @snuyanzin Thanks for the pr. Sorry for the late response for I'm busy with other things. I'll definitely have a look in next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1826369560 rebased since there were new commits in main flink master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1395670915 ## .github/workflows/push_pr.yml: ## @@ -25,4 +25,4 @@ jobs: compile_and_test: uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils with: - flink_version: 1.16.0 + flink_version: 1.19-SNAPSHOT Review Comment: yes, with last 2 commits 1.18 is supported. there could be 2 ways: support it for 1.18.0 first only and then apply similar approach to adapt updates from 1.19 or support it for both 1.19 and 1.18 like here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1395573572 ## .github/workflows/push_pr.yml: ## @@ -25,4 +25,4 @@ jobs: compile_and_test: uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils with: - flink_version: 1.16.0 + flink_version: 1.19-SNAPSHOT Review Comment: initial commit is based on master however let's see if there could be done support for 1.18.0 there are several things which are required to be workaround like FLINK-32620, FLINK-25593 and some others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
snuyanzin commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1395573572 ## .github/workflows/push_pr.yml: ## @@ -25,4 +25,4 @@ jobs: compile_and_test: uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils with: - flink_version: 1.16.0 + flink_version: 1.19-SNAPSHOT Review Comment: initial commit is for master however let's see if it could be done for 1.18.0 there are several things which are required to be workaround like FLINK-32620, FLINK-25593 and some others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
MartijnVisser commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1395286033 ## .github/workflows/push_pr.yml: ## @@ -25,4 +25,4 @@ jobs: compile_and_test: uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils with: - flink_version: 1.16.0 + flink_version: 1.19-SNAPSHOT Review Comment: Is the externalization based on the code from the `release-1.18` branch or master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]
boring-cyborg[bot] commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1813564070 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
