Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
JingsongLi merged PR #665: URL: https://github.com/apache/flink-web/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on PR #665: URL: https://github.com/apache/flink-web/pull/665#issuecomment-1776598050 @carp84 Thanks for the review, I had already removed the links to the legacy Paimon (flink-table-store) and only left a link to the incubating-paimon doc. From the discussion, I think guys have similar ideas to drop the legacy links, and it seems no obvious opinion against to link to the latest paimon docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
carp84 commented on PR #665: URL: https://github.com/apache/flink-web/pull/665#issuecomment-1776537954 @Myasuka I respect the consideration of recording the history, whereas the history is already recorded in the below ways (which explicitly show that Paimon origins from Flink Table Store), besides this PR: 1. The incubation [proposal](https://cwiki.apache.org/confluence/display/INCUBATOR/PaimonProposal) and [discussion](https://lists.apache.org/thread/hr3d7tpw02w6ybrnnlf3hcbhfxotwpvn) of Paimon 2. The [announcement](https://lists.apache.org/thread/pz5f9cvpyk4q9vltd7z088q5368v412t) that Flink Table Store joins Apache incubator as Paimon And we will send another email to our Flink user/dev mailing lists if one day Paimon graduates as a Top-Level-Project (you have my word). It's not bad to be nostalgic, but let's move forward to the future (smile) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on PR #665: URL: https://github.com/apache/flink-web/pull/665#issuecomment-1774663958 Already updated this PR, please take a review again @JingsongLi @MartijnVisser . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
MartijnVisser commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368214182 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.org/flink/flink-table-store-docs-master/; Review Comment: I understand that, but I don't think we should link to the legacy docs from the main menu. It will just redirect users to outdated content, while they should be checking out the latest docs. Paimon could consider linking to the old docs from their project website. Another approach would be that the announcement of Paimon itself would be posted as a Flink blog, and that includes links to the old doc versions there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368207827 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.org/flink/flink-table-store-docs-master/; Review Comment: ~~I think we should still host the docs of legacy version of Paimon for users, and it seems we cannot find the legacy docs of older version via Paimon's website. That's why I prefer to keep it.~~ **Update:** I found we can get the link from [Paimon's website](https://paimon.apache.org/docs/0.4/versions/), even it is not easy to find, I think users could still get it. If so, I think we can remove the legacy link and keep the link to the latest Paimon's doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368207827 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.org/flink/flink-table-store-docs-master/; Review Comment: I think we should still host the docs of legacy version of Paimon for users, and it seems we cannot find the legacy docs of older version via Paimon's website. That's why I prefer to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
MartijnVisser commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368202283 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.org/flink/flink-table-store-docs-master/; Review Comment: Why? With Paimon now becoming its own project, I don't think we should per se link to it from the Flink project website. The history of Flink can always be found in Git anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368093090 ## docs/content.zh/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) Review Comment: Since flink-table-store-0.3 is the last version when Paimon is part of Flink and cannot be known from Apache Paimon's website. I prefer to keep the link here if someone wants to review the history of Apache Paimon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1367670600 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.org/flink/flink-table-store-docs-master/; Review Comment: I prefer to keep this file as flink-table-store was part of history of Flink, and developers/users could still find the valid legacy links if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
